jrottenberg / ffmpeg

Docker build for FFmpeg on Ubuntu / Alpine / Centos / Scratch / nvidia / vaapi
https://hub.docker.com/r/jrottenberg/ffmpeg/
Apache License 2.0
1.42k stars 454 forks source link

libx265 need nasm 2.13 for version >2.6 #166

Open shlagevuk opened 5 years ago

shlagevuk commented 5 years ago

Hi, When testing different version of libx265 I've found that nasm is not installed but needed in libx265 version 2.7 (see patch note). That lead to having libx265 running 6 times slower.

To fix this we need to add nasm >= 2.13 in the packages list but debian and ubuntu only have older version in their repositories.

I've made a workaround by downloading directly the debian multimedia package and installing it with dpkg. RUN wget http://www.deb-multimedia.org/pool/main/n/nasm-dmo/nasm_2.13.01-1.1_amd64.deb && dpkg -i nasm_2.13.01-1.1_amd64.deb

But I think it's not the proper way to do it.

remingtonc commented 5 years ago

Using 18.04 as base potentially solves this issue, 2.13+ is bionic package. https://packages.ubuntu.com/bionic/nasm