search

jrottenberg / ffmpeg

Docker build for FFmpeg on Ubuntu / Alpine / Centos / Scratch / nvidia / vaapi
https://hub.docker.com/r/jrottenberg/ffmpeg/
Apache License 2.0
1.38k stars 452 forks source link

Obtain the VMAF (Video Multi-Method Assessment Fusion) score between two input videos. #257

Open brycechesternewman opened 3 years ago

brycechesternewman commented 3 years ago

Hello, Is there a reason why (perhaps legal or just not considered) that https://ffmpeg.org/ffmpeg-filters.html#libvmaf can not be added? Thank you.

jrottenberg commented 3 years ago

No legal reason, just technical, there was an attempt : https://github.com/jrottenberg/ffmpeg/pull/127

But based on older version of the repo, I'll try to save it, unless you want to take a stab at it.

brycechesternewman commented 3 years ago

I can give it a try. This is the file you are talking about https://github.com/jrottenberg/ffmpeg/pull/127/files? Which will need a VMAF version upgrade of course.

jrottenberg commented 3 years ago

Right basically https://github.com/jrottenberg/ffmpeg/pull/127/commits/89295bb32d2b8701539286c05f25be52b9bdc616 was correct,

  1. update the templates accordingly (Dockerfile-env and Dockerfile-run)
  2. run ./update.py to propagate the changes on all variants/versions
  3. test
brycechesternewman commented 3 years ago

Yep. Got some time to read through the code. Nice work on the Dockerfile-env and Dockerfile-run.

brycechesternewman commented 3 years ago

Do you need to give me permissions to push a branch? "remote: Permission to jrottenberg/ffmpeg.git denied to..."

jrottenberg commented 3 years ago

you need to create a fork, and push to your local repo, once you are happy with your changes, open Pull requests your_repo:your_branch against jrottenberg/ffmpeg:master