search

jrottenberg / ffmpeg

Docker build for FFmpeg on Ubuntu / Alpine / Centos / Scratch / nvidia / vaapi
https://hub.docker.com/r/jrottenberg/ffmpeg/
Apache License 2.0
1.37k stars 450 forks source link

Unused flag "MAKEFLAGS" #311

Closed Xantios closed 1 year ago

Xantios commented 2 years ago

in the dockerfile the variable "MAKEFLAGS" is defined (default with "-j2") changed it out to "-j24") but the variable is defined and never used?

anything Im missing here?

bstivers commented 1 year ago

I know this is old. You've probably figured it out by now. But I figured I would reply anyway.

It's a docker build argument for an environment variable that can be changed during docker build. e.g. docker build --build-arg MAKEFLAGS=-j24 -f Dockerfile .

There's no need to change it within the main Dockerfile

The environment variable is automatically picked up by all make commands as if it were entered in as make -j24.

reference: 5.7.3 Communicating Options to a Sub-make