search

jrottenberg / ffmpeg

Docker build for FFmpeg on Ubuntu / Alpine / Centos / Scratch / nvidia / vaapi
https://hub.docker.com/r/jrottenberg/ffmpeg/
Apache License 2.0
1.37k stars 450 forks source link

Support (compile/link) of VMAF on ubuntu2004/nvidia2004 #330

Open eyalf-nvidia opened 2 years ago

eyalf-nvidia commented 2 years ago

I'm pretty new to this project but i am targeting to use the 4.4-ubuntu2004 and 4.4-nvidia2004 in order to to Encode, Decode and run Measurements (PSNR/SSIM/VMAF).

I have noticed that both don't have VMAF fully supported "out of the box". The ubuntu2004 template file is slightly different from other template files in the fact that at the "cleanup" step of the build Stage, it copies from ${PREFIX}/share/ only the ffmpeg directory rather than all the artifacts (see HERE) while other templates use a * (see HERE) in the copy (this for example misses-out VMAF's models directory).

Also, in the nvidia2004 template, meson is missed-out in the buildDeps which in turns, disables the compilation/deployment of VMAF.

I guess i was wondering if these are actual decisions or have just been missed-out and can be fixed? I would definitely prefer avoiding building the docker myself but rather use the the one on Docker Hub.

jrottenberg commented 2 years ago

Oh, yeah I think they are just inconsistencies , due to missed-out, definitely should be fixed. At least I can recall why the difference. Don't hesitate to submit a patch if that prevents you to use the image.