jrottenberg / ffmpeg

Docker build for FFmpeg on Ubuntu / Alpine / Centos / Scratch / nvidia / vaapi
https://hub.docker.com/r/jrottenberg/ffmpeg/
Apache License 2.0
1.37k stars 450 forks source link

H.264 tar balls are no longer updated in https://download.videolan.org/pub/videolan/x264/snapshots #333

Open brycechesternewman opened 2 years ago

brycechesternewman commented 2 years ago

According to this issue https://code.videolan.org/videolan/x264/-/issues/8 H.264 tar balls are no longer updated in https://download.videolan.org/pub/videolan/x264/snapshots/x264-snapshot-20191218-README.txt.

Locally I have updated to use https://code.videolan.org/videolan/x264/-/archive/stable/x264-stable.tar.bz2. FFmpeg 5.0 was compiled with r3060 "264 - core 163 r3060 5db6aa6 - H.264/MPEG-4 AVC codec - Copyleft 2003-2021 - http://www.videolan.org/x264.html".

The proposed change is below, but I can't see how to use a specific version, but that may not matter. I can put in a pull request for this but wanted to feedback before I make this change to use the proposed new tar ball location for the Dockerfiles...

RUN \
        DIR=/tmp/x264 && \
        mkdir -p ${DIR} && \
        cd ${DIR} && \
        curl -sL https://code.videolan.org/videolan/x264/-/archive/stable/x264-stable.tar.bz2 | \
        tar -jx --strip-components=1 && \
        ./configure --prefix="${PREFIX}" --enable-shared --enable-pic --disable-cli && \
        make && \
        make install && \
        rm -rf ${DIR}