Closed crocdialer closed 4 months ago
I tried adding -Wextra to CMakelists.txt but the number of errors is just too much. On clang we're also disabling this warning, so I did the same for gcc now.
nice, can confirm that works for me :)
Note that Sonar will still find unused parameters, but it's a bit smarter about them.
yeah, the usage of JPH_GCC_SUPPRESS_WARNING
does have the downside of unconditionally disabling those warnings for all compilation-units (indirectly) including Core.h
. and I can imagine how cumbersome it would be to try limiting the scope of those ignores (e.g. wrapping with diagnostic push/pop). anyway, thanks a lot, that was helpful!
They are wrapped in a push/pop:
warnings occurred when including 'Jolt/Physics/Collision/Shape/MeshShape.h'. this commit comments out unused parameters of
MeshShape::GetSubmergedVolume
ubuntu 22.04, gcc 11.4.0