Improved handling of mass override for soft bodies

jrouwe / JoltPhysics

A multi core friendly rigid body physics and collision detection library. Written in C++. Suitable for games and VR applications. Used by Horizon Forbidden West.

MIT License

6.42k stars 414 forks source link

Improved handling of mass override for soft bodies #1066

Closed jrouwe closed 4 months ago

jrouwe commented 4 months ago

If inverse mass override of both the soft body vertex and the colliding body are 0, the collision will be ignored
If the inverse mass override of the soft body vertex is 0 and the colliding body is kinematic, the collision will be ignored
If the sensor flag is set, the collision will be reported but not handled

jrouwe commented 4 months ago

@mihe I think with this change you can remove your hack:

https://github.com/godot-jolt/godot-jolt/blob/5876f86281a28c5f5071b21f84415489f61d427e/src/spaces/jolt_contact_listener_3d.cpp#L140-L145

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mihe commented 4 months ago

That does indeed resolve that issue it seems.

Thank you!