jrouwe / JoltPhysics

A multi core friendly rigid body physics and collision detection library. Written in C++. Suitable for games and VR applications. Used by Horizon Forbidden West.
MIT License
6.65k stars 438 forks source link

Added explicit setting of exception/RTTI flags when enabled #1210

Closed mihe closed 2 months ago

mihe commented 2 months ago

This obviously isn't strictly necessary, but I was toying around with trying to mismatch these new options with the values of CMAKE_ANDROID_EXCEPTIONS and CMAKE_ANDROID_RTTI, and found that even when explicitly enabling something like CPP_RTTI_ENABLED while disabling CMAKE_ANDROID_RTTI you end up with RTTI disabled in Jolt, which struck me as odd.

Clang doesn't seem to emit any warnings about one flag overriding the other either, which makes this even more precarious, so I figured it's better to just be explicit about it.

jrouwe commented 2 months ago

Thanks!