replace as.character with format for R4.3

jrowen / rhandsontable

A htmlwidgets implementation of Handsontable.js

http://jrowen.github.io/rhandsontable/

Other

385 stars 148 forks source link

replace as.character with format for R4.3 #431

Open klin333 opened 1 year ago

klin333 commented 1 year ago

in R4.3 the following could give warning:

rhandsontable::rhandsontable(data.frame(x = Sys.Date()))
# Warning message:
# In as.character.POSIXt(as.POSIXlt(x), ...) :
#   as.character(td, ..) no longer obeys a 'format' argument; use format(td, ..) ?

This pull request fixes it

petersmp commented 7 months ago

I am also running into this issue. It looks like this PR would fix the issue.

J-flem commented 4 months ago

Thank you for this branch @klin333. Hopefully it can be pulled into the main branch soon

jjjpellinen commented 2 months ago

Ran into this issue a year ago https://github.com/jrowen/rhandsontable/issues/427.

This will fix it. And somehow it seems surprisingly time consuming to merge these 2 lines.