search

jrparish / tslint-webpack-plugin

TSLint plugin for Webpack
MIT License
20 stars 9 forks source link

fix: Use lowercase for ruleSeverity #32

Closed a-carvallo closed 3 years ago

a-carvallo commented 3 years ago

In tslint rule severity is lowercase, so the comparison in the plugin would never be true, and we end up with only errors or only warnings (but not a mix) depending on the value of options.warningsAsError.

jrparish commented 3 years ago

Thanks for the PR!

Has this always been the case or was this a change to tslint? Do we need to handle both cases?

jrparish commented 3 years ago

Actually I'm pretty sure its always been this way. I'll go ahead and merge this and we can add support for both cases if it causes any grief

a-carvallo commented 3 years ago

Thank you, and yes I think it was always like that, I had a project with tslint 5.15.0 (so from 2 years ago) and it was already lowercase.

jrparish commented 3 years ago

Published 2.1.1