search

jrquick17 / ng-speed-test

A light weight Angular 2+ library for checking internet speed
https://ng-speed-test.jrquick.com
MIT License
12 stars 3 forks source link

File size unit is wrong #59

Closed mwmw7 closed 1 year ago

mwmw7 commented 1 year ago 
// https://raw.githubusercontent.com/jrquick17/ng-speed-test/02c59e4afde67c35a5ba74014b91d44b33c0b3fe/demo/src/assets/500kb.jpg
// 500kb      // 408949 kb

I think 408949 bytes is right

README and comments have wrong unit

image

jrquick17 commented 1 year ago

This is a known discrepancy which we do call out in the README. dgns

The code does use the exact byte size so the speed checks out of the box should be accurate. Ideally the image would be exactly 500kb but not a priority at the moment. If you have images that match then feel free to submit a pull request.