jrraul4 / Portafolio-Personal

MIT License
0 stars 0 forks source link

peer-to-peer code review #8

Open IsraArvin opened 1 year ago

IsraArvin commented 1 year ago

Hey there! 👋 I took a look at your #7 CSS code and wanted to suggest a quick improvement regarding vendor prefixes. Here's what you can do:

1️⃣ In the .contact-Button class:

2️⃣ In the .contact-Button button:hover block:

These additions will ensure your code works smoothly across different browsers. Let me know if you have any questions or need further assistance!

Happy coding! ✨🚀

ammarAlaliS commented 1 year ago

Hello José, good work, but there are comments that I want to give you about the html code in the contact section. I recommend that you use the tag label , it will really help you to follow a good structure in your page.

IvonneBenitesRodriguez commented 1 year ago

Hello Jose, Your code is very organized and clean. I would only kindly suggest you to check the line 142 in your stylesheet, since I noticed, you used the background property with its styles, you can use CSS Shorthand property, so you can set all background styles at once. Here a resource that can be useful to you: https://developer.mozilla.org/en-US/docs/Web/CSS/background