search

jrs95 / hyprcoloc

Hypothesis Prioritisation in multi-trait Colocalization
https://jrs95.github.io/hyprcoloc/
GNU General Public License v3.0
46 stars 12 forks source link

error in vignette? #24

Open auton1 opened 1 year ago

auton1 commented 1 year ago

The vignette includes the following sentence:

if N denotes the total number of overlapping participants and ${N{i},N{j}}$ denote the numbers of participants in the $i$'th and $j$'th studies respectively, then $N/\left(N{i}N{j}\right)$ is the $(i,j)=(j,i)$ element.

Apologies if I misunderstand this, but shouldn't the denominator include a square root? i.e.

... then $N/ \sqrt{ \left(N{i}N{j}\right)}$ is ...

Thanks.

jrs95 commented 1 year ago

@cnfoley would you mind responding to Adam?