search

jrschumacher / Gmail-StrikeThrough

Google Chrome extension for strikethrough within Gmail including Google Apps
9 stars 3 forks source link

Broken by Gmail's new look #2

Closed OlderBudWeiser closed 12 years ago

OlderBudWeiser commented 13 years ago

Doesn't work in Gmail's new look (https://mail.google.com/mail/help/intl/en/newlook.html). Strike through icon doesn't appear.

ghost commented 12 years ago

I can confirm this. No strike through button in the 'new look'. When I toggle back to the 'old book' (which will permanently disappear soon) the button is there.

jrschumacher commented 12 years ago

I have fixed this in the new version. Update your extension and you should be good to go! Thanks for the support and input.

OlderBudWeiser commented 12 years ago

Thanks. The new version isn't on the Chrome store yet, so can't update. Installed version is 1.2.1, which appears to be the current one. Is it just a matter of time until your changes are propagated to the store server and then to us? __ Fred

On Mon, Dec 12, 2011 at 10:14 AM, Ryan Schumacher < reply@reply.github.com

wrote:

I have fixed this in the new version. Update your extension and you should be good to go! Thanks for the support and input.

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3107177

jrschumacher commented 12 years ago

No, 1.2.1 is the version I was referring to and it works with new version of Gmail. I am still working on the enhanced version.

Ryan Schumacher twitter / @jrschumacher http://twitter.com/jrschumacher

On Mon, Dec 12, 2011 at 10:46 AM, OlderBudWeiser < reply@reply.github.com

wrote:

Thanks. The new version isn't on the Chrome store yet, so can't update. Installed version is 1.2.1, which appears to be the current one. Is it just a matter of time until your changes are propagated to the store server and then to us? __ Fred

On Mon, Dec 12, 2011 at 10:14 AM, Ryan Schumacher < reply@reply.github.com

wrote:

I have fixed this in the new version. Update your extension and you should be good to go! Thanks for the support and input.

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3107177

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3108613

dansimau commented 12 years ago

I have upgraded to 1.2.1 and can confirm I still don't see the strike-through using the "Desk" HD Theme and the "Compact" Display Density.

OlderBudWeiser commented 12 years ago

Thanks for your reply.

Not sure what you mean by enhanced. My issue was using it with Gmail's new look. Doesn't show upno Strikethrough icon between Underline and Font.

The new look probably required a new icon.

Will the new, enhanced version you're working on support other styles? Subscript and Superscript are the ones I'd like. Personally, I can do without Underline. I'd like to see a dropdown menu on the icon for selecting styles and the character in the icon show the currently selected style, and it's fine if strike, sub and super are mutually exclusiveonly one of this group could be applied. (Might get hairy if a block of text that includes sub or sup gets struck out. The strikethrough line should continue at the same height and thickness in the cell for the width of the subscript or superscript. OK. So sub & sup are mutually exclusive. Strike is another independent style, like B, I & U.)

P.S. I think the new look's monochrome edit toolbar and the new icons suck. I generally try to adapt to UI changes, try them for a while and not just react. But having used the new look for a while, I really do think the old ones were better. The little red X on Remove Formatting was easy to spot. With color, the icons for text and background color icons were more suggestive. The Text Color icon looks like an underline. The old script F for Font is more mnemonic than the block letter T that replaced it and visually does a better job of suggesting the icon's function. Not sure why they want smaller, simpler icons. I assume it has something to do with making it easier for apps for mobile phones and other resource-constrained devices.

On Mon, Dec 12, 2011 at 11:53 AM, Daniel Simmons < reply@reply.github.com

wrote:

I have upgraded to 1.2.1 and can confirm I still don't see the strike-through using the "Desk" HD Theme and the "Compact" Display Density.

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3108725

On Mon, Dec 12, 2011 at 11:48 AM, Ryan Schumacher < reply@reply.github.com

wrote:

No, 1.2.1 is the version I was referring to and it works with new version of Gmail. I am still working on the enhanced version.

Ryan Schumacher twitter / @jrschumacher http://twitter.com/jrschumacher

On Mon, Dec 12, 2011 at 10:46 AM, OlderBudWeiser < reply@reply.github.com

wrote:

Thanks. The new version isn't on the Chrome store yet, so can't update. Installed version is 1.2.1, which appears to be the current one. Is it just a matter of time until your changes are propagated to the store server and then to us? __ Fred

On Mon, Dec 12, 2011 at 10:14 AM, Ryan Schumacher < reply@reply.github.com

wrote:

I have fixed this in the new version. Update your extension and you should be good to go! Thanks for the support and input.

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3107177

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3108613

Reply to this email directly or view it on GitHub:

https://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-3108641

ghost commented 12 years ago

FWIW, I am seeing the strike-through icon now. Didn't go through any upgrade process; it was just automagically there. @OlderBudWeiser Totally agree with you on the (now colorless) 'remove formatting' button. This is exacerbated, IMO, by using 'T' for the font, size, highlite, and remove format buttons. Now I have to carefullt mouse-over each one to see what it is. :\

dansimau commented 12 years ago

Yeah, like witlessmusings I'm now seeing the strike through button too. Still on version 1.2.1 so not sure what changed...

jrschumacher commented 12 years ago

@dansimau v1.2.1 uses content scripts instead of background scripts and fixes for new Gmail. No real "features" yet.

jrschumacher commented 12 years ago

@witlessmusings @OlderBudWeiser I need to work on the icon some just was more focused on getting it working for the new Gmail. Will post some design ideas too based on feedback. Please post any feature request/brainstorming here: https://github.com/jrschumacher/Gmail-StrikeThrough/issues/3

fcherman commented 11 years ago

Not working for me either. Version 25.4.1364.99

jrschumacher commented 11 years ago

Thank you for the report. I will be taking a look tonight and see if I can figure out how to fix it. Googles changes to the UI has made things difficult to hook into.

On Wednesday, February 27, 2013, fcherman wrote:

Not working for me either. Version 25.4.1364.99

— Reply to this email directly or view it on GitHubhttps://github.com/jrschumacher/Gmail-StrikeThrough/issues/2#issuecomment-14191177 .

Ryan Schumacher

twitter / @jrschumacher http://twitter.com/jrschumacher