search

jrsconfitto / language-powershell

PowerShell language support for the Atom editor
https://atom.io/packages/language-powershell
Other
44 stars 17 forks source link

Include specific keyword descriptors #59

Open dizzi90 opened 6 years ago

dizzi90 commented 6 years ago

See morkro/atom-emoji-syntax#50. I don't understand enough about this works to explain the problem properly, but it seems morkro has explained it well in the issue referenced.

I briefly checked the language-powershell package, and it doesn't really come with meaningful syntax descriptors. That means I can't add emoji to specific keywords, as they're too generic. :(

Would love to add support, but the way atom-emoji-syntax is build it requires meaningful keyword selectors.

Edit: I checked some more code examples, and found that Function does have a specific specifier. I could at least support for that.

It seems like replicating what has been done with the Function keyword would be adequate.

I would like to see selectors for classes, workflows, control structures, scopes, attributes, etc.

If you tell me how I will happily attempt make a pull request, but I would need quite a detailed guide, so it might be less work to just do it. Also, tell me if there is any research I can do to help the issue to be solved.

@morkro: If I have misrepresented the issue, please correct me.

jrsconfitto commented 6 years ago

Thanks for letting me know, i'll take a look into what we'd need to support it. If work is needed, i'll share what's involved.

In the past, i attempted to move to a different grammar provided by the powershell/editorsyntax repo but pulled it back due to some regressions. Perhaps the regressions are worth it at this point, or maybe they are no longer present.

morkro commented 6 years ago

@dizzi90 All good :)

@jrsconfitto I can help out, if you need any assistance in updating the grammar.