search

jrstarke / webview-debug

Enables debugging of WebViews withing Android for Cordova Apps
Apache License 2.0
74 stars 17 forks source link

cannot use with phonegap build service #3

Open dotnetwise opened 10 years ago

dotnetwise commented 10 years ago

Cannot use with phonegap build service. Can you please submit your plugin to phonegap 3rd party plugins?

$ phonegap remote run android 
[phonegap] compressing the app...
[phonegap] uploading the app...
   [error] {"error":"plugin unsupported: com.jamiestarke.webviewdebug"}
dotnetwise commented 10 years ago

I have tried to submit it to Adobe Phonegap build service, but they say

The license of the plugin must be 'MIT' or 'Apache 2.0'

Can you please update your licensing of the plugin to either one of the two?

jrstarke commented 10 years ago

Sorry, I misunderstood what you were looking for. I've updated the license, and submitted it to PhoneGap Build. It's currently undergoing review, but you probably won't be able to see that page until it gets accepted.

dotnetwise commented 10 years ago

No problem. This will help anyone quickly enabling the debugger without installing the plugin itself / doing local build. Just adding <gap:plugin name="com.jamiestarke.webviewdebug" /> would enable it!

Thank you!

p5hema2 commented 10 years ago

Hi, is there any status update on the review.

dotnetwise commented 10 years ago

I can't seem to find it released either :(

jrstarke commented 10 years ago

There appears to be a bug blocking my submission (http://community.phonegap.com/nitobi/topics/getting_unable_to_clone_git_repository_when_submitting_a_plugin_update-osqln?rfm=1)

jrstarke commented 10 years ago

After looking into it for a few minutes, it appears that this is supported directly in PhoneGap 3.3.0 (https://github.com/apache/cordova-android/blob/3.3.0/framework/src/org/apache/cordova/CordovaWebView.java#L299), and based on feedback of PhoneGap Build, my plugin can only accept 3.2.0 or higher, it make little sense to resubmit this. I advise you to move up to Cordova 3.3.0, and it should just work if you have the debuggable flag enabled.