search

jrsteensen / OpenHornet-Software

Repo for all the software that brings OpenHornet to life!
Other
13 stars 8 forks source link

[Bug]: CI Pipeline Failing on missing SPI.h File #102

Open Arribe opened 3 months ago

Arribe commented 3 months ago

Discord Username

Arribe

Bug Summary

PR #101 is failing with entry: /home/runner/work/OpenHornet-Software/OpenHornet-Software/libraries/Arduino-FOC-drivers/src/encoders/mt6835/./MT6835.h:8:10: fatal error: SPI.h: No such file or directory
8 | #include "SPI.h" | ^~~ compilation terminated.

Expected Results

The sketch should compile as SPI.h is a base library included with all Arduino platforms.

Actual Results

The CI fails to complete with the error the SPI.h file is missing. I even tried including it at the top of the include list on the main sketch.

Screenshots/Images/Files

image

Applicable File Names

PR 4A9A1-THROTTLE_CONTROLLER.ino #101

Release Version

v0.3.0

Category

Libraries & Dependencies (Arduino Libraries, etc)

Applicable End Item(s)

Throttle

Hardware is built to print & this software is tested on that hardware?

Miscellaneous Info

No response

jrsteensen commented 3 months ago

Have we tried installing the library as a submodule and calling it that way?

Arribe commented 3 months ago

It's a submodule header call from SimpleFOC...I didn't want to cause problems by adding a base Arduino header as a submodule...but I can certainly try it to see if that works.

Arribe commented 3 months ago

No luck. Adding the core ArduinoCore-avr as a sub module didn't work...and probably caused more problems since that is a base library that's included in every Arduino IDE. Adding SPI.h and SPI.cpp didn't work and caused more header files to be marked as missing.

Arribe commented 3 months ago

As far as I can tell ESP32 CI is broken. Trying a test sketch consisting of basically an empty file except including Wire.h or SPI.h CI fails. Though based on what I can see the following fragments should lead the CI to reaching those files:

OpenHornet Software's include/esp.mk has this line: ESP_ROOT = $(ROOTDIR)/libraries/arduino-esp32

makeEspArduino /makeEspArduino.mk has the following line: ESP_LIBS = $(ESP_ROOT)/libraries

Then following the OpenHornet Software libraries folder links to the github entry below for ESP_ROOT/libraries: https://github.com/espressif/arduino-esp32/tree/4b3aebe11fa5acc0f8b259105b4d1990b95c399b/libraries

The libraries folder has SPI, Wire directories.