bug_106_fix for DDI controller.

[Arribe]

Description

Same issue as bug 104, with backlighting and controls becoming unresponsive at random times.

Closes #106

Dependencies

• List any dependencies that are required for this change, including a full list of libraries required, especially if it is a new or otherwise unused library in the OpenHornet software.

Type of change

• [ ] New software module (new software module for slave)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update outside of the automatically-generated Doxygen documentation.

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have complied with the software manual for this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code fully with Doxygen compatible comments, particularly in hard-to-understand areas
• [x] I have made corresponding changes to non-Doxygen generated documentation
• [x] I have ran Doxygen locally, and it builds the docs successfully
• [x] My changes generate no errors on compile in Arduino IDE
• [x] My changes generate no new warnings on compile in Arduino IDE
• [x] Any dependent changes have been merged and published in downstream modules
• [x] (For sketches only) This sketch complies with OH-INTERCONNECT v10
• [x] If this sketch requires additional libraries, I have added it as a sub-module per the Arduino Libraries section of the Software Manual.

How Has This Been Tested?

• [x] I have tested the sketch in-circuit in DCS with DCS-BIOS and outputs (displays, LEDs, etc.) function as expected.
• [ ] I have tested the sketch in-circuit in DCS with DCS-BIOS and HID inputs (switches, pots, etc.) function as expected, with switches moving the correct direction.
• [ ] I have tested the sketch in-circuit in DCS with DCS-BIOS and any logic in the sketch has been tested and functions as expected.
• [ ] This code has not yet been tested in-circuit.
• [ ] This code has not yet been tested in DCS-BIOS.

Description of Testing

Tested in DCS, and via the monitor to ensure that the buttons work. Pressed them multiple times, more than what was typically needed to cause the unresponsive issue.

Test Configuration

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

[Arribe]

@jrsteensen Just flew a full mission without any hiccups on the DDIs disconnecting. This PR can be merged.

[kbastronomics]

We do need to understand this fix better for 2 reasons.

1. it makes no sense to why it fixes this issue (not disagreeing it fixes the issue)
2. the fix implies that IRQ cannot be used which would be a blocker for their usage

[jrsteensen]

We do need to understand this fix better for 2 reasons.

1. it makes no sense to why it fixes this issue (not disagreeing it fixes the issue)
2. the fix implies that IRQ cannot be used which would be a blocker for their usage

We will eventually do a hardware update to support IRQ on the DDI's but we have way too many in the wild that we should support with software. Will track #614 for next major DDI controller revision if required.