jrsteensen / OpenHornet

OpenHornet 1:1 F/A-18C Simulator Repository
https://www.openhornet.com
Other
320 stars 111 forks source link

[Bug]: multiposition rotary switches: Every position needs a connection. #1083

Closed Higgins-OH closed 3 months ago

Higgins-OH commented 3 months ago

Discord Username

Higgins

Bug Summary

Since it isn't possible (at least right now) to program the multiposition switches for DCSBios in a way that the "off" position is recognized without a connection, every single position needs to be connected. The switches missing one connection with available pins on the board are as follows:

Connection missing, but not enough available pins:

Expected Results

Every position needs to be recognized by DCSBios. Connection needed.

Actual Results

The "off" position isn't connected.

Screenshots/Images/Files

No response

Applicable Part Numbers

OH-Interconnect (here: v13)

Release Version

v0.2.0

Category

Electrical (PCBs/Wiring/etc)

Applicable End Item(s)

Top Level Assembly (TLA)

Built to print?

Miscellaneous Info

No response

Arribe commented 3 months ago

Issue is in the Software repository, and logged with skunkworks. DCSBios has a PIN_NC option allowing for a single switch pin to not be connected. DCSBios doesn’t handle it correctly, so we’ve coded around that in the current software sketches that have these switches.

Higgins-OH commented 3 months ago

Alright, I'll give it a try. If it works flawlessly, then the comment can be removed (5A5A1-ECS_PANEL.ino, develop branch):

"@bug The Bleed Air knob rotation bounces to NORM when rotated, potentially needs a hardware resolution to connect the NORM position to an Arduino pin. */"

Arribe commented 3 months ago

Not 100% sure about removing the comment. Out of all of the rotary switches the bleed air knob is the toughest for me to rotate within the debounce window. The knob doesn’t have a definite click and from months of use I’ve had it bounce around. In practice it’s not that big a deal, because having it bounce between positions while rotating doesn’t really mess up the sim like if the INS bounces to off and the Jett losses qual. If others have a different experience for bleed air then we can remove the bug, until then I was just calling it out for awareness.

kbastronomics commented 3 months ago

Issue is in the Software repository, and logged with skunkworks. DCSBios has a PIN_NC option allowing for a single switch pin to not be connected. DCSBios doesn’t handle it correctly, so we’ve coded around that in the current software sketches that have these switches.

What was the issue that was opened with DCS-BIOS, do they plan a fix? looking at the "FIX" here, any change to DCS-BIOS could break it including a change to PIN_NC.

kbastronomics commented 3 months ago

it was #57, and #58 they've not accepted or done anything with either