jrsteensen / OpenHornet

OpenHornet 1:1 F/A-18C Simulator Repository
https://www.openhornet.com
Other
320 stars 112 forks source link

D1 Diode silkscreen incorrect in Hall Effect Sensor board #584

Closed geeman-nz closed 1 year ago

geeman-nz commented 2 years ago

Summary:

The silkscreen for the Hall effect sensor PCB is incorrect. It displays that the diode should be placed in the incorrect orientation, leading to the polarity being backwards.

Expected Results/How It Should Work:

The + symbol should be placed on the opposite side to where it is currently placed

Screenshots:

Note the diode is placed in opposite polarity to the marked silkscreen. This image was produced by a JLCPCB engineer when this issue was questioned.

Produce_DanZhi SMT_Snapshot Top 3633949A_Y15 SMT02211071017825 (2)

More Information

Add an "X" in the square brackets to check the applicable checkboxs.

Category:

Check one or more items.

Exprezz0 commented 1 year ago

@geeman-nz Is there any reason why the Diode can't be rotated 180 degrees instead of adjusting the silkscreen? The + symbol indicates the correct pad.

image

Arribe commented 1 year ago

From ordering experience this is confusing. Shouldn't the silkscreen reflect the direction of the diode and not which pad is '+'? There are instances for using reversed polarity diodes. image

Exprezz0 commented 1 year ago

image

Will be closed with #592

jrsteensen commented 1 year ago

@Exprezz0 - for brevity, just add the K to the left side, no arrow. Stays more consistent with single character markings of other polarities. Drop the A. (If you don't mind - if you already implemented it, don't worry about it. Nothing I'm going to lose sleep over.)

Exprezz0 commented 1 year ago

Too easy. Just figured I'd alleviate all doubt. Fixed and updated.