[core] fix legacy binds when directly using exec_* methods

jruby / activerecord-jdbc-adapter

JRuby's ActiveRecord adapter using JDBC.

BSD 2-Clause "Simplified" License

461 stars 385 forks source link

[core] fix legacy binds when directly using exec_* methods #1035

Closed dr-itz closed 5 years ago

dr-itz commented 5 years ago

Works with AR, breaks with AR-JDBC. Fix it by pushing the conversion down to the actual methods, remove the higher-level wrappers.

Fixes #1033

dr-itz commented 5 years ago

CI's ok, the failing one is unrelated. Caused by a test ordering issue, didn't happen in my own run: https://travis-ci.org/dr-itz/activerecord-jdbc-adapter/builds/590877761

kares commented 5 years ago

looks good, seems that this is only problematic with AR 5.2 ... no need to get this for < 5.2 right?

dr-itz commented 5 years ago

hmm...maybe it would make sense for < 5.2, but that never worked. Those wrappers I removed with this commit were added for 5.2 only :). Might as well just have 52 and add them back to 50/51 later if required. Should also be easier to merge.