search

jruby / activerecord-jdbc-adapter

JRuby's ActiveRecord adapter using JDBC.
BSD 2-Clause "Simplified" License
462 stars 385 forks source link

fix(mysql): fix dependency for jdbc-mysql #1083

Closed dr-itz closed 3 years ago

dr-itz commented 3 years ago

Spotted by @mohamedhafez

mohamedhafez commented 3 years ago

@enebo or @headius, would you guys mind taking a look at this? It seems like jdbc-mysql has been unintentionally locked to jdbc-mysql versions 5.1.*, causing https://github.com/jruby/activerecord-jdbc-adapter/issues/1082. If that's indeed unintentional it would be really nice to get that fixed up!

reidmorrison commented 3 years ago

@enebo or @headius, would you mind please merging this PR, since it will really help out our JRuby production deployment? We have MySQL 8 in production and JRuby is still stuck on the MySQL 5.7 drivers, even though the new v8 drivers are available in the latest jdbc-mysql.

enebo commented 3 years ago

I will spind new releases this week. Sorry I missed this one. Thanks to @dr-itz again!

enebo commented 3 years ago

This has been updated for 52.x, 60.x, and 61.x. Our build system is all for one and one for all so you will notice all gems were released in this project when only mysql gemspec was changed....Weird but the time to fix it is not time I want to take right now.

reidmorrison commented 3 years ago

Thank you @enebo, appreciate your help, the MySQL 8 JDBC drivers are working very well in production. :tada: