search

jruby / activerecord-jdbc-adapter

JRuby's ActiveRecord adapter using JDBC.
BSD 2-Clause "Simplified" License
461 stars 385 forks source link

Bump sqlite-jdbc adapter #1119

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 2 years ago

For M1 support, as per https://stackoverflow.com/questions/70048681/java-sql-sqlexception-error-opening-connection.

Not sure what this upgrade involves, but this does get things going on my machine.

Fixes #1118.

headius commented 2 years ago

Do we still need this?

deivid-rodriguez commented 2 years ago

This did fix the error I was getting on my M1 Mac, so I thought I'd contribute it upstream.

headius commented 2 years ago

@deivid-rodriguez Thanks!

headius commented 2 years ago

@deivid-rodriguez @kares @enebo We should push this through sooner than later, but this is still marked as a draft and I'm not sure which branch we should move forward with.

deivid-rodriguez commented 2 years ago

It's only mark as draft because CI is red, and I never checked whether it was related to my changes or not. But this worked for me when I tried it.

deivid-rodriguez commented 2 years ago

I marked it as ready just in case its WIP status makes merging harder.

headius commented 2 years ago

We should probably put out a release of this soon, unless there are other important items to fix right now.

kares commented 2 years ago

fixing those safe_yaml tests would be nice to do at some point, maybe even excluding the failing Rails test.

after the jdbc- gem is pushed the change should merge back to master as well ...

let me know if there are any issues and I will look into releasing the updated driver gem.