search

jruby / docker-jruby

MIT License
18 stars 27 forks source link

update to version 1.7.23 #12

Closed jtarchie closed 8 years ago

jtarchie commented 8 years ago

This adds support for JRuby 1.7.23.

cpuguy83 commented 8 years ago

LGTM, thanks!

jtarchie commented 8 years ago

Thanks, @cpuguy83. I've noticed that some of the official docker repos for some runtimes are out of date. More than happy to help with PRs, but on my project we have a notification (Slack message and Pivotal Tracker story) system that let's us know of new releases of several runtimes (JRuby included). Any interest in something like that?

@flavorjones, since this was accepted, expect a PR on your side soon.

cpuguy83 commented 8 years ago

@jtarchie For this it was mostly time/prioritization, and it came while I was on vacation.

Did you want to go ahead and make the PR to github.com/docker/docker-library to update the commit/version info?

jtarchie commented 8 years ago

This repo (github.com/docker/docker-library) does not exist. What is the next step to getting this deployed?

cpuguy83 commented 8 years ago

sorry - https://github.com/docker-library/official-images

jtarchie commented 8 years ago

@cpuguy83 going to be honest. Read the README.md and still don't understand what pull request needs to be made.

cpuguy83 commented 8 years ago

See docker-library/official-images#1344

Basically, we have to update that repo under library/jruby with the commit sha from this PR, and update the version numbers (remove .22->.23)

jtarchie commented 8 years ago

Sounds like this needs to be automated.

automate all the things

I'll get on this.