search

jruby / docker-jruby

MIT License
18 stars 27 forks source link

Alpine jruby 9k image #18

Closed albertogg closed 8 years ago

albertogg commented 8 years ago

Hi, I notice the repo is missing the alpine image and that #9 was a bit outdated but that was something wanted. I decided to work in this a bit and did the alpine image for jruby 9k using JRE base image as a starting point. I could work in the others if needed but, I have a few questions:

1) Do you guys think that JDK, JRE and on-build images will be needed? 2) Depending in answer 1 what would be the desired folder structure?

Thanks,

cpuguy83 commented 8 years ago

@albertogg Thanks for doing this! Just a couple of minor comments.

albertogg commented 8 years ago

@cpuguy83, done!

What about the other images? and the dir structure?

cpuguy83 commented 8 years ago

@albertogg If you're up for it I'll take it. Thanks!

albertogg commented 8 years ago

@cpuguy83 sure I can, I was thinking on doing jruby 9k in this pull request and open another for 1.7. I just don't know what would be the correct or desired dir structure.

Currently there's this:

tree .
.
├── 1.7
│   ├── jdk
│   │   └── Dockerfile
│   ├── jre
│   │   └── Dockerfile
│   └── onbuild
│       └── Dockerfile
├── 9000
│   ├── alpine
│   │   └── Dockerfile
│   ├── jdk
│   │   └── Dockerfile
│   ├── jre
│   │   └── Dockerfile
│   └── onbuild
│       └── Dockerfile
└── LICENSE.md

What I'm not sure of is if I should rename the 9000/alpine dir to 9000/alpine-jre and so on. What's you take on this?

cpuguy83 commented 8 years ago

alpine-jre and alpine-jdk are good (assuming there is an alpine:jdk-1.8)

albertogg commented 8 years ago

yes, both jre and jdk images are available! let me go for it then, thanks

albertogg commented 8 years ago

done with both jruby 9k images jdk and jre.

cpuguy83 commented 8 years ago

Sorry, 2 more comments, and can you squash to 1 commit?

albertogg commented 8 years ago

done!

albertogg commented 8 years ago

Hi, I just want to ask what's the status of this? Sorry if I'm being annoying.

cpuguy83 commented 8 years ago

Sorry, just tested. LGTM.

Thanks! Image is about 1/2 the size of the debian based one. Good job!

albertogg commented 8 years ago

Thanks! 🎊

cpuguy83 commented 8 years ago

PR to update official images: docker-library/official-images#1920