search

jruby / docker-jruby

MIT License
18 stars 27 forks source link

JRuby with JRE 17 #83

Closed nfrankel closed 1 year ago

nfrankel commented 1 year ago

Hello,

Is there a particular reason why there's no jruby:9.4 with JRE 17?

If not, I'll be happy to provide a PR.

headius commented 1 year ago

JRE has largely been deprecated now, hasn't it? We certainly could add it, but I was under the impression that there was no JRE anymore and everyone just ships the full JDK.

nfrankel commented 1 year ago

Don't take it wrongly but I don't know what gave you this impression.

Not only is a JDK's image larger than a JRE's, but its attack surface is also larger because of it. In particular, it contains a compiler (that's the idea) and that's a huge security risk in production IMHO.

headius commented 1 year ago

I think I got the impression because some shops supporting JDK stopped building JREs, but I have no issues with adding JRE modes for all of the images we push. PR would be great!

nfrankel commented 1 year ago

Thanks for the explanation.

Here's the PR: https://github.com/jruby/docker-jruby/pull/84