search

jruby / jcodings

Java-based codings helper classes for Joni and JRuby
MIT License
20 stars 29 forks source link

[build] fix target java version #43

Closed ahorek closed 2 years ago

ahorek commented 2 years ago

this PR fixes mvn test on recent java versions

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project jcodings: Compilation failure: Compilation failure:
[ERROR] Source option 6 is no longer supported. Use 7 or later.
[ERROR] Target option 6 is no longer supported. Use 7 or later.

btw is it still important to keep java 7 compatibility?

ahorek commented 2 years ago

I've also switched to github actions, because java 9 is currently broken on travis. Please enable it on the repository, thanks!

headius commented 2 years ago

Will do on the actions... Travis is dead, long live GHA!

headius commented 2 years ago

Actions are not currently disabled but I think we need a workflow to get things moving. I will try to get it functioning today.

headius commented 2 years ago

Oh and...

btw is it still important to keep java 7 compatibility?

Probably not. Anyone that needs 7 can probably use 8.

headius commented 2 years ago

I pushed the simple GHA workflow that GitHub provides and it appears to have run with one failure in TestCP51932ToCP50220.