jruby / jcodings

Java-based codings helper classes for Joni and JRuby
MIT License
21 stars 29 forks source link

improve test for jp #51

Closed ahorek closed 2 years ago

ahorek commented 2 years ago

the problem here is most probably with different data types. We do store tbl0208 table as byte[] and CRuby stores char[]

https://github.com/jruby/jcodings/blob/0a3f5790c78e54f587b6468b671dc630444ff5c3/src/org/jcodings/transcode/TranscodeFunctions.java#L541

CRuby comparison https://github.com/ruby/ruby/blob/545d6820715a48a17d6182128c0db4198dfa76c1/enc/trans/iso2022.trans#L465

I tested the spec against CRuby. Besides, it does check the actual output, so it should be more reliable than the original version. It should pass after a proper fix.