search

jruby / jcodings

Java-based codings helper classes for Joni and JRuby
MIT License
20 stars 29 forks source link

test escape apos #52

Closed ahorek closed 2 years ago

ahorek commented 2 years ago

a test for https://bugs.ruby-lang.org/issues/16922

it should pass after tables update from https://github.com/jruby/jcodings/pull/49 but there's still a problem

TestEConv.testEscapeApos:90 expected:<&amp;[&apos;&amp;]> but was:<&amp;[]>

am I doing something wrong? or is there something else that should be adjusted?

ref https://github.com/jruby/jcodings/pull/45

headius commented 2 years ago

Hmm not sure what the issue is here.

ahorek commented 2 years ago

' should now be escaped as &apos; the same way as & is escaped as &amp;

but the test fails and I didn't find out where the problem is.

ahorek commented 2 years ago

since it's passing on the latest JRuby snapshot that includes this change, there's probably something wrong with the test itself.

https://github.com/jruby/jcodings/issues/56 will be the ultimate solution for a better coverage

closing