search

jruby / jruby-openssl

JRuby's OpenSSL gem
http://www.jruby.org
Other
47 stars 80 forks source link

Fix SSLContext#ciphers= #222

Closed MariuszCwikla closed 3 years ago

MariuszCwikla commented 3 years ago

Fixes #221 and jruby/jruby#3100

However, this functionality is not fully compatible with ruby openssl. I did some investigation and apparently jruby-openssl was implemented based on openssl 0.9.x. Ruby 2.7 is using openssl 1.1.1. There was a refactoring in openssl between 0.9.x and 1.1.1, e.g. following does work with ruby, but not with jruby:

c.ciphers='AES128'

but this works with both:

c.ciphers='AES'
p-mongo commented 3 years ago

Thank you for fixing this.

p-mongo commented 3 years ago

This looks a-ok to me but I didn't verify exact behavior against MRI.

headius commented 3 years ago

This is a good step forward! I will merge this but we need to do more verification and get a release out.