search

jruby / jruby-openssl

JRuby's OpenSSL gem
http://www.jruby.org
Other
47 stars 80 forks source link

revisit compatibility with gemified net/http #249

Open kares opened 2 years ago

kares commented 2 years ago

JRuby had a few modification to net/http in stdlib to work-around APIs JOSSL does not provide (e.g. session_new_cb=) as well as some custom Java specific features (using the JVM system proxy).

ATM, once a gem-ifiied net/http is installed further gem install starts failing with the relevant errors e.g.

OpenSSL::SSL::SSLContext#session_cache_mode= has no effect under JRuby
ERROR:  While executing gem ... (NoMethodError)
    undefined method `session_new_cb=' for #<OpenSSL::SSL::SSLContext:0x1782896>
Did you mean?  session_id_context=

We could provide dummy APIs (such as session_new_cb=) even if they would do nothing as long as net/http does not rely on them as "mission critical" and they do not interfere with TLS security.

Upstream case (for JRuby 9.4): https://github.com/jruby/jruby/pull/7088

kares commented 2 years ago

for the record a net/http patch has been posted that handles JRuby compatibility: https://github.com/ruby/net-http/pull/52