jruby / jruby-rack

Rack for JRuby and Java appservers
MIT License
397 stars 137 forks source link

[to-do] towards **1.2** #168

Open kares opened 10 years ago

kares commented 10 years ago

JRuby-Rack 1.2 is aimed as a cleanup release which might break some binary compatibility with 1.1.x when its worth (a badly designed API or due performance reasons). This should only affect users even when they explicitly depend on JRuby-Rack APIs - the very most users won't be affected at all.

No one seems to be working towards 1.2 much currently. If you're interested in seeing some of these enhancements/features/performance work get in touch or show some support at BountySource

JasonLunn commented 7 years ago

Would it be possible to get a release based off of master? In particular, the map logger levels 1-to-1 feature would really be helpful.

kares commented 7 years ago

@JasonLunn unfortunately its not release ready - quite far from it. that one features might be semi-complete ... although only on my fork. am also thinking about forms of monetization for the extended features since obviously there's little help and I can not manage support after a release on my own. in the end it might never get completed - it is what it is for now, take it or use a Java logger library with some Ruby sugar.

JasonLunn commented 7 years ago

I tried to drop a locally built 1.2 gem into a fresh proof-of-concept app but I got the error below:

SEVERE: javax.servlet.ServletContext log: error app failed to handle exception: org.jruby.exceptions.RaiseException: (ArgumentError) wrong number of arguments calling `info` (0 for 1)
org.jruby.exceptions.RaiseException: (NoMethodError) undefined method `bytesize' for Rack::Utils:Module
    at RUBY.call(uri:classloader:/jruby/rack/error_app/show_status.rb:30)
    at org.jruby.rack.ext.Servlet.call(org/jruby/rack/ext/Servlet.java:83)
kares commented 7 years ago

as I said its likely quite broken, you're on your own here - the ext parts are a WiP. might drop a pre-release in a week or two.

JasonLunn commented 7 years ago

What's your process for debugging this gem? I would take a stab at producing a backport of logger-level mapping, but I don't know of a way to attach a ruby debugger to a running Tomcat process.

kares commented 7 years ago

sorry but I do not thing its such a good idea (for 1.1) since it's a noticeable back-wards incompatible change. e.g. users will experience "disappearing" logs unless they configure the native backend appropriately (which in some cases with certain servers and setup might not be an option). would need additional work to be a opt-in feature. as I said you're pretty much on your own here. feel free to get in touch privately if its quite crucial for you guys - we could figure smt out on the clock. my 'free' oss support slot is pretty much 'vacant' :) I am only going to spent time on this on the way I like to ...