search

jruby / jruby-rack

Rack for JRuby and Java appservers
MIT License
397 stars 137 forks source link

Runtime error not logging specific message #213

Closed daneshd closed 2 years ago

daneshd commented 6 years ago

I recently upgraded a rails app and was deploying it to our staging environment with warbler. Every time I made a web request to it though, I kept hitting an unknown error. The only message I saw in my tomcat logs was resetting rack response due exception.

After getting some help from some fine folks in the jruby IRC channel, they suggested to make an issue to see if there's enough info being logged. Perhaps I just missed the error message or have misconfigured something? They mentioned that the web response being sent back should have included something about the error but I didn't see anything. I'm guessing it may be because I was running things in staging and that Rails just redirects to my 500.html error page instead of showing any info on the error.

I included the exception message in this log and hacked together a build to test for myself. That helped me solve my own issue but it probably doesn't hurt to have this in place for others.

rosenjcb commented 6 years ago

Adding the error e would be super helpful. I recommend the pull request (or something equivalent) be accepted.

seanstory commented 4 years ago

Looks like this was "fixed" back in 2018, but there hasn't been a release since then. Any plans to release with this fix?

headius commented 3 years ago

@seanstory Ahh yeah sorry about that. The folks that had been maintaining this library moved on to other things, so it has been mostly dormant.

@kares @enebo @jkutner @mkristian We really need to get this project going again, because issues are piling up. Can we have a chat at some point about how to transition this to new maintainers? Mostly we need to figure out who can be responsible for monitoring issues and get a general status about how we verify and push releases now.

kares commented 2 years ago

seems to have been handled at https://github.com/jruby/jruby-rack/pull/214 and is now available in 1.1.22