search

jruby / jruby-rack

Rack for JRuby and Java appservers
MIT License
397 stars 136 forks source link

Remove usage of Rack::Utils.bytesize #252

Closed jlahtinen closed 3 months ago

jlahtinen commented 4 months ago

See also https://github.com/rack/rack/commit/7b5820f8de7f9dffeb03d86588bba13fb0e91df1

enebo commented 4 months ago

LOL. I guess CI is still not quite there.

@jlahtinen Can you also fix: src/main/ruby/jruby/rack/error_app.rb for the same use of bytesite. That should eliminate any use of that method.

headius commented 3 months ago

CI looks fine, it's just that the dependency upload part (for GitHub security checking) is not working (and disabled on master for that reason).

I'm going to merge this for 1.2.3 and we can chat with @kares if a similar fix and update to newer Rack would be appropriate for 1.1.x.

headius commented 3 months ago

Correction: disabled except for master because PRs should not upload dependencies.