search

jruby / ruby-maven

Eclipse Public License 2.0
1 stars 5 forks source link

Make `rvmn` exit with a meaningful exit status #1

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

If the command it run under the hood failed, it should respect its status and fail too.

Helps with https://github.com/jruby/jruby-openssl/issues/199.

Also made an extra change so that the test suite at least starts.

deivid-rodriguez commented 4 years ago

You might want to enable TravisCI in this repo, by the way :)

kares commented 4 years ago

Awesome David, thanks for looking into this. @enebo any chance we could merge, bump and than push this to RGs?

deivid-rodriguez commented 4 years ago

No problem!

headius commented 4 years ago

Looks good, and +1 on getting testing enabled.

headius commented 4 years ago

We can release if we're ready for this, but there's at least one other open issue we should perhaps address.