jruesga / rview

A Gerrit client application for Android
Apache License 2.0
66 stars 21 forks source link

Fix a few issues reported by Lint #34

Closed sschuberth closed 7 years ago

sschuberth commented 7 years ago

This doesn't fit the lint error warning, and the original code is properly scaped.

Correct that it does not make the Lint warning go away, I've clarified the commit message in that regard. But I believe it's not correct that the original code was correctly escaped. As the linked StackOverflow answer shows, only the opening angle bracket should be escaped.

jruesga commented 7 years ago

Both sentence are ok. What makes the build fails is the < instead of &lt;, because that breaks the xml parsing. The second can be represented in the two ways. Since the first one need to be escaped, I opted by escape the second one too. I prefer to keep it as it is, and disable the lint warning with an inline annotation.

sschuberth commented 7 years ago

I prefer to keep it as it is, and disable the lint warning with an inline annotation.

Done.

jruesga commented 7 years ago

Thanks