search

jruesga / rview

A Gerrit client application for Android
Apache License 2.0
66 stars 21 forks source link

Can't connect to private gerrit instance #42

Closed vlotorev closed 7 years ago

vlotorev commented 7 years ago

Registering the private Gerrit instance in Rview ends with 'Endpoint is not Gerrit instance error'.

Server uses self signed certificate. The same URL opens in browser without issues. I have to accept certicate though.

jruesga commented 7 years ago

Thanks for the bug report. Fixed in https://github.com/jruesga/rview/commit/765b9f9bac3f53e52a05f7dae3e92538301236fe

You still need to check "Trust all server certificates" on the repository's wizard page. Be aware that this option could expose the connection between your device and your gerrit service instance to MITM attacks, since the app must trust in any certificate presented by the server.

vlotorev commented 7 years ago

Great. Thanks for fixing it - that was fast. When will this commit be available as release on Google Play?

jruesga commented 7 years ago

I will do a release tonight.