search

jruesga / rview

A Gerrit client application for Android
Apache License 2.0
66 stars 21 forks source link

Spanish translation #6

Closed SferaDev closed 6 years ago

SferaDev commented 8 years ago

Translations in specific projects where English terms are commonly used across languages is not easy. We should consider if only adding Settings/Wizard ones would be enough.

jruesga commented 8 years ago

Yep, that is my main concern to not create the Spanish strings myself (the most difficult word to translate is "Merged"; I don't find a good translation in Spanish for this word), and this is a tool for devs, and all devs undestood this english concept, at least anyone that previously worked with Gerrit (event its interface is not translated).

Said that, if we are going to translate this to Spanish, it's all or nothing. I don't want spanish-english strings :) (that doesn't look serious).

And the Wizard, also has its own strings in https://github.com/jruesga/rview/blob/master/wizard/src/main/res/values/strings.xml

I will review the strings later and add my comments to the patchset.

Thanks for strings.

jruesga commented 8 years ago

@SferaDev I'm going to hold this PR for now. If there are more translation requests, I will review and submit this. Thx.

SferaDev commented 8 years ago

Sure, going with all the strings doesn't feel right wither as there're a lot of them that doesn't make sense in Spanish.