search

jrwe / crypto-js

Automatically exported from code.google.com/p/crypto-js
1 stars 0 forks source link

cannot load MD5 and SHA-1 in the same page #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. in an HTML file, include scripts/crypto-md5/crypto-md5.js (from the 
latest downloadable zip file)
2. also include scripts/crypto-sha1/crypto-sha1.js
3. the Crypto.MD5 function will not be available (you get an error if you 
try to use it)
4. remove scripts/crypto-sha1/crypto-sha1.js
5. the Crypto.MD5 function is now available

What is the expected output? What do you see instead?
I expect to be able to use both the Crypto.MD5 and Crypto.SHA1 (and 
Crypto.SHA256)  in the same page.

What version of the product are you using? On what operating system?
crypto-js 2.0.0
OS is Linux (Ubuntu 9.10)
Browser = Firefox 3.5.8

Please provide any additional information below.
It seems crypto-sha1.js overwrites the Crypto object, thus removing the 
Crypto.MD5 function
This is probably true for all the Crypto.* methods

Original issue reported on code.google.com by bradcu...@gmail.com on 9 Apr 2010 at 4:43

GoogleCodeExporter commented 9 years ago 
Ah, I think this is due do the js compressor, which seems to merge the 
crypto.js file 
with one of the hash files (like md5.js or sha1.js). So including crypto-md5.js 
and 
crypto-sha1.js does redefine the Crypto object.

For the sake of others reading this, the correct way do use both MD5 and SHA1 
in the 
same page is to include 3 separate files:
crypto/crypto.js
md5/md5.js
sha1/sha1.js

Then everything works fine.

So I guess it's not a bug, but what do you think? Worth mentioning in the docs 
somewhere?

Original comment by bradcu...@gmail.com on 9 Apr 2010 at 4:56

GoogleCodeExporter commented 9 years ago 
At minimum, worth mentioning in the docs.

Future versions will either prevent the crypto object from being overwritten, 
or throw an error to at least alert the developer to what it happening.

Original comment by Jeff.Mott.OR on 18 Jun 2010 at 5:49

GoogleCodeExporter commented 9 years ago 
awesome, thanks for the response

Original comment by bradcu...@gmail.com on 20 Jun 2010 at 3:12

GoogleCodeExporter commented 9 years ago 
Fixed in revision 292.

Original comment by Jeff.Mott.OR on 7 Mar 2011 at 3:58