search

jrwrigh / csv2cash

Python package for importing CSV files to GNUCash
GNU General Public License v3.0
23 stars 7 forks source link

Check Compatibility with updated piecash version #17

Open jrwrigh opened 5 years ago

jrwrigh commented 5 years ago

piecash has now updated to include support for GNUCash 3.0 (version 1.0.0 of piecash). Just need to double check to make sure it works.

EntPyle commented 3 years ago

any partucular features or just see if the example runs? I could write tests if its particular features. Or we could do a general compatibilty check (does it run) and test critical features (Transaction access, validation, etc)

jrwrigh commented 3 years ago

Just checking to see if the example works is probably good enough. The previous version of csv2cash was running an early of branch of piecash that was merged without any changes iirc, so that should be good enough.

EntPyle commented 3 years ago

I just ran the example with piecash<=1.1.2 and it worked. All transactions are in test.gnucash and are categorized, paired, or ignored (in the duplicate test case) as needed. Building a test script to test the features and tell the users which, if any of the tests failed specifically would still be an improvement on running this example script.

Edit: I'll put together some test scripts and make a pull request.

jrwrigh commented 3 years ago

I'll put together some test scripts and make a pull request.

That'd be awesome! I honestly haven't put too much priority on this project since it was kind of a one-use thing I made (and was primarily an excuse for playing around with Python). Implementing an actual testing script (even if it's not full unit testing) would be a great addition.

EntPyle commented 3 years ago

So while I'm likely still going to branch to make a gui for something like this package, I may still be able to make some functional tests for you. Once I get further into it this week, I'll confirm or cancel my commitment.

On Sun, Dec 13, 2020, 5:58 PM James Wright notifications@github.com wrote:

I'll put together some test scripts and make a pull request.

That'd be awesome! I honestly haven't put too much priority on this project since it was kind of a one-use thing I made (and was primarily an excuse for playing around with Python). Implementing an actual testing script (even if it's not full unit testing) would be a great addition.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jrwrigh/csv2cash/issues/17#issuecomment-744092188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ7MPEKXEQ553OVPXYE4ITSUVILBANCNFSM4IOWZIUA .