search

jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

Documentation fix #116

Closed amirsaar closed 3 years ago

amirsaar commented 3 years ago

'drain_node_with_spec' wasn't documented correctly, documentation said to use drain_node which doesn't support the spec in it's signature

codecov-commenter commented 3 years ago

Codecov Report

Merging #116 (fcaa4a7) into master (7c1bca8) will decrease coverage by 8.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   78.80%   70.57%   -8.23%     
==========================================
  Files          26       26              
  Lines        1203     1203              
==========================================
- Hits          948      849      -99     
- Misses        255      354      +99
Impacted Files Coverage Δ
nomad/api/deployments.py 48.71% <0.00%> (-41.03%) :arrow_down:
nomad/api/acl.py 58.33% <0.00%> (-33.34%) :arrow_down:
nomad/api/operator.py 76.47% <0.00%> (-23.53%) :arrow_down:
nomad/api/node.py 46.25% <0.00%> (-22.50%) :arrow_down:
nomad/api/deployment.py 58.49% <0.00%> (-20.76%) :arrow_down:
nomad/api/client.py 72.91% <0.00%> (-16.67%) :arrow_down:
nomad/api/job.py 73.07% <0.00%> (-12.83%) :arrow_down:
nomad/api/metrics.py 92.30% <0.00%> (-7.70%) :arrow_down:
nomad/api/validate.py 92.30% <0.00%> (-7.70%) :arrow_down:
nomad/api/base.py 53.33% <0.00%> (-5.19%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c1bca8...fcaa4a7. Read the comment docs.