jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

update base._query_string_builder to take params as argument #120

Closed jrxFive closed 3 years ago

jrxFive commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #120 (bc7f668) into master (0d462bd) will increase coverage by 11.80%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #120       +/-   ##
===========================================
+ Coverage   78.80%   90.61%   +11.80%     
===========================================
  Files          26       26               
  Lines        1203     1065      -138     
===========================================
+ Hits          948      965       +17     
+ Misses        255      100      -155     
Impacted Files Coverage Δ
nomad/api/base.py 97.59% <100.00%> (+39.07%) :arrow_up:
nomad/api/client.py 87.77% <0.00%> (-1.81%) :arrow_down:
nomad/api/job.py 94.36% <0.00%> (+8.46%) :arrow_up:
nomad/api/deployment.py 93.33% <0.00%> (+14.08%) :arrow_up:
nomad/api/node.py 84.61% <0.00%> (+15.86%) :arrow_up:
nomad/__init__.py 98.23% <0.00%> (+43.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d462bd...bc7f668. Read the comment docs.