search

jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

add scaling policy endpoint #136

Closed nikita-b closed 1 year ago

nikita-b commented 1 year ago

I added scaling-policies endpoints: https://developer.hashicorp.com/nomad/api-docs/scaling-policies#read-scaling-policy

I can add more tests, but we need merge PR with scaling related operations: https://github.com/jrxFive/python-nomad/pull/131

codecov-commenter commented 1 year ago

Codecov Report

Merging #136 (dce5157) into master (690add1) will decrease coverage by 0.14%. The diff coverage is 84.00%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   90.61%   90.47%   -0.15%     
==========================================
  Files          27       28       +1     
  Lines        1130     1155      +25     
==========================================
+ Hits         1024     1045      +21     
- Misses        106      110       +4
Impacted Files Coverage Δ
nomad/api/scaling.py 80.00% <80.00%> (ø)
nomad/__init__.py 98.36% <100.00%> (+0.05%) :arrow_up:
nomad/api/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nikita-b commented 1 year ago

@jonathanrcross @jrxFive Could we fix or disable Publish Test PyPi step? CI is broken because of it :(

jonathanrcross commented 1 year ago

It took me awhile to realize that the "failure" is due to https://github.com/pypa/gh-action-pypi-publish/discussions/49. I'll add the push event that should fix this from failing.

nikita-b commented 1 year ago

@jonathanrcross Thanks!