search

jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
141 stars 74 forks source link

Add variables endpoint #141

Closed nikita-b closed 1 year ago

nikita-b commented 2 years ago

Added support for /var and /vars endpoints: https://developer.hashicorp.com/nomad/api-docs/variables

codecov-commenter commented 2 years ago

Codecov Report

Merging #141 (2f20dad) into master (da760de) will increase coverage by 0.79%. The diff coverage is 97.45%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   90.47%   91.26%   +0.79%     
==========================================
  Files          28       31       +3     
  Lines        1155     1271     +116     
==========================================
+ Hits         1045     1160     +115     
- Misses        110      111       +1
Impacted Files Coverage Δ
nomad/api/namespaces.py 57.50% <0.00%> (ø)
nomad/api/search.py 95.83% <95.83%> (ø)
nomad/__init__.py 98.50% <100.00%> (+0.14%) :arrow_up:
nomad/api/__init__.py 100.00% <100.00%> (ø)
nomad/api/base.py 96.62% <100.00%> (+0.07%) :arrow_up:
nomad/api/exceptions.py 100.00% <100.00%> (ø)
nomad/api/variable.py 100.00% <100.00%> (ø)
nomad/api/variables.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nikita-b commented 2 years ago

@jonathanrcross @jrxFive I finished PR, could you review it, please? When we'll merge the PR I think we can release 1.5.0 (I changed the version in setup.py).

@ViViDboarder Could you also re-review, please? It was just a draft and I wasn't ready for review 😄