jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

update parameters in `Job` functions #153

Closed IgnacioHeredia closed 1 year ago

IgnacioHeredia commented 1 year ago

Just a little update on the parameters in deregister_job(). Tested it.

I choose Union instead of Optional for parameters in line with this.

codecov[bot] commented 1 year ago

Codecov Report

Merging #153 (2c8e250) into master (364f063) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   90.63%   90.71%   +0.08%     
==========================================
  Files          31       31              
  Lines        1292     1293       +1     
==========================================
+ Hits         1171     1173       +2     
+ Misses        121      120       -1     
Impacted Files Coverage Δ
nomad/api/job.py 94.52% <100.00%> (-0.08%) :arrow_down:

... and 4 files with indirect coverage changes

nikita-b commented 1 year ago

@IgnacioHeredia Could you, please, fix the linters?

IgnacioHeredia commented 1 year ago

@nikita-b done!

nikita-b commented 1 year ago

LGTM, @IgnacioHeredia thanks for your contribution!

nikita-b commented 1 year ago

@IgnacioHeredia Oh, it seems we still have an issue with black formatter.

IgnacioHeredia commented 1 year ago

@nikita-b done!