Put "Diff" parameter into the request body

jrxFive / python-nomad

Client library Hashicorp Nomad

https://python-nomad.readthedocs.io/en/latest/

MIT License

139 stars 73 forks source link

Put "Diff" parameter into the request body #61

Closed jeteon closed 6 years ago

jeteon commented 6 years ago

As explained in #60, the Diff parameter should be in the request payload rather than a GET parameter. This change puts it into the payload. A different dictionary is constructed for the payload to avoid unexpectedly modifying the passed in dictionary.

jeteon commented 6 years ago

I should add a test for this. I'll try to check how the existing tests work so I can add one.

jonathanrcross commented 6 years ago

Nice catch, @jeteon. Should be good to go, once we add a test.

jeteon commented 6 years ago

Sorry for taking so long getting back to you with the tests.

jonathanrcross commented 6 years ago

No worries @jeteon, its a safe change! Thanks again.