search

jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

Added support for optional `purge` parameter in job.deregister. #77

Closed xbreak closed 5 years ago

xbreak commented 5 years ago

I use python-nomad for our integration tests, and for that I want to clean up properly which means to remove all traces of jobs after the test run. Nomad supports this with the optional purge parameter which I now added.

Looking at the test implementation it looks like the tests have ordering dependencies (test_delete_job is re-registering the job afterwards) so I added the test which purges at the bottom and finally also reregister the job. If subsequent tests depend on a built up state (job versions for example), this could lead to issues down the line.

codecov-io commented 5 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   91.14%   91.19%   +0.04%     
==========================================
  Files          26       26              
  Lines        1028     1033       +5     
==========================================
+ Hits          937      942       +5     
  Misses         91       91
Impacted Files Coverage Δ
nomad/api/job.py 94.36% <100%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50955af...c9ff8b3. Read the comment docs.