pserranoa commented 5 years ago

if you are working with vault as your secret backed, and you wish to *ensure vault security, you must enable the following parameter at your configuration: https://www.nomadproject.io/docs/configuration/vault.html#allow_unauthenticated

At this pull request, I have tryed to make the following task:

Unify travis and vagrant configuration of nomad and vault daemons using one file. start_daemons.sh
Configure travis to execute several test with diferent version of vault product. Vault has 2 diferentes types of backends: (simple secrets and versioned secrets)
I writed documentation about vault and nomad integration with several samples.
I writed diferents test with a container that publish a secret stored at vault to validate the integration.

I hope you can review and analyse if this pull request could be at your project as part of it

Best regards

codecov-io commented 5 years ago

Codecov Report

Merging #83 into master will decrease coverage by 0.01%. The diff coverage is 90%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.02%     
==========================================
  Files          26       26              
  Lines        1033     1042       +9     
==========================================
+ Hits          942      950       +8     
- Misses         91       92       +1

Impacted Files	Coverage Δ
nomad/api/base.py	`97.7% <100%> (+0.17%)`	:arrow_up:
nomad/__init__.py	`96.8% <66.66%> (-1%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3eb383...0f8dd9d. Read the comment docs.

pserranoa commented 5 years ago

Hi @jrxFive , did you have time to analize this pull request? This make sense for you?

jrxFive / python-nomad

Secret backend integration with Vault. #83

Codecov Report