search

jrxFive / python-nomad

Client library Hashicorp Nomad
https://python-nomad.readthedocs.io/en/latest/
MIT License
139 stars 73 forks source link

Adding __str__ method to improve errors readability #94

Closed SlipJ closed 4 years ago

SlipJ commented 5 years ago

Improving the custom errors readability so that it will also include the response that caused it. Also removing the inherited init method.

codecov-io commented 5 years ago

Codecov Report

Merging #94 into master will decrease coverage by 0.13%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
- Coverage   91.23%   91.1%   -0.14%     
=========================================
  Files          26      26              
  Lines        1038    1034       -4     
=========================================
- Hits          947     942       -5     
- Misses         91      92       +1
Impacted Files Coverage Δ
nomad/api/exceptions.py 88.88% <50%> (-11.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b74ac41...8fca9e4. Read the comment docs.

jrxFive commented 4 years ago

Hey @SlipJ, thanks so much for the PR/improvement to the exception string dunder!