erhlee-bird commented 5 years ago

https://nomadproject.io/guides/security/securing-nomad.html

When using Nomad in a secured fashion, allow the user to specify environment variables NOMAD_CLIENT_CERT and NOMAD_CLIENT_KEY to specify custom a cert and key.

This behavior matches that of the official Nomad cli.

codecov-io commented 5 years ago

Codecov Report

Merging #96 into master will decrease coverage by 0.13%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
- Coverage   91.23%   91.1%   -0.14%     
=========================================
  Files          26      26              
  Lines        1038    1034       -4     
=========================================
- Hits          947     942       -5     
- Misses         91      92       +1

Impacted Files	Coverage Δ
nomad/__init__.py	`97.8% <100%> (ø)`	:arrow_up:
nomad/api/exceptions.py	`88.88% <0%> (-11.12%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b74ac41...7a349ea. Read the comment docs.

erhlee-bird commented 4 years ago

Thanks for reviewing @jrxFive and the awesome library. I've added the two new environment variables under the environment variables section in the README.

jrxFive / python-nomad

support NOMAD_CLIENT_CERT and NOMAD_CLIENT_KEY #96

Codecov Report